set custom Interpolate for mapController #1834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @ankiimation!
Thank you for your PR. My remarks:
- we should have the same behavior as before by default, therefore as if there was no interpolator
- obviously we need a setter - maybe a getter
- not sure: should it be the same interpolator for map and zoom?
| @@ -48,6 +52,7 @@ public class MapController implements IMapController, OnFirstLayoutListener { | |||
| private double mTargetZoomLevel = 0; | |||
|
|
|||
| private Animator mCurrentAnimator; | |||
| public TimeInterpolator interpolator = new AccelerateDecelerateInterpolator(); | |||
There was a problem hiding this comment.
Suggested change
| public TimeInterpolator interpolator = new AccelerateDecelerateInterpolator(); | |
| private TimeInterpolator mInterpolator; |
| @@ -166,6 +171,7 @@ public void animateTo(final IGeoPoint point, final Double pZoom, final Long pSpe | |||
| if (mCurrentAnimator != null) { | |||
| mapAnimatorListener.onAnimationCancel(mCurrentAnimator); | |||
| } | |||
| mapAnimator.setInterpolator(interpolator); | |||
There was a problem hiding this comment.
Suggested change
| mapAnimator.setInterpolator(interpolator); | |
| mapAnimator.setInterpolator(mInterpolator); |
| @@ -400,8 +406,9 @@ public boolean zoomToFixing(double zoomLevel, int xPixel, int yPixel, Long zoomA | |||
| } else { | |||
| zoomToAnimator.setDuration(zoomAnimationSpeed); | |||
| } | |||
|
|
|||
| zoomToAnimator.setInterpolator(interpolator); | |||
There was a problem hiding this comment.
Suggested change
| zoomToAnimator.setInterpolator(interpolator); | |
| zoomToAnimator.setInterpolator(mInterpolator); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.