Added get_route api function & aidl get_position #9304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chumva
reviewed
Jun 25, 2020
| * | ||
| * @params positionType (int) - type of position to get | ||
| */ | ||
| boolean getPosition(in int positionType, out APosition position); |
There was a problem hiding this comment.
New aidl methods must be added to the end of the file or following methods will be broken.
|
Is there any plan to integrate this merge request? I'm interested in having these features in the API. |
|
Probably this request will be merged next week. I will check it once more on the weekend and fix some issues. |
|
Hello! Yes, I am going to do it but was little bit busy in school with all that documents to get into next class. I have already made one more feature (getting of route creation time (ID)) and I think today I will do |
… & getRouteCreationTime();
|
Have made all the changes, ready to pull |
ehermann
reviewed
Jul 21, 2020
…ed getRoute() aidl api method; added getRoutePoints() aidl method
|
this request is probably going to be merged soon, so please don't add any extra methods which could be included in another request. |
ehermann
reviewed
Jul 22, 2020
| @@ -1344,6 +1344,19 @@ public boolean getRoutePoints(List<ALatLon> route) { | |||
| return false; | |||
| } | |||
|
|
|||
| @Override | |||
| public String getApplicationMode() { | |||
There was a problem hiding this comment.
getApplicationMode can be misleading. Unless I'm wrong you are not getting the current application mode, but the application mode at the moment the route was created.
If you are interested in getting the current application mode, maybe creating a generic function getSettings that is somewhat symmetrical to the setCustomization can be an alternative.
vshcherb
reviewed
Jul 30, 2020
| */ | ||
| String getApplicationMode(); | ||
| } |
There was a problem hiding this comment.
It should be refactored into 3 differnet methods:
- getCalculatedRoute - information about calculated routes, geometry, appmode, time, etc
- getApplicationMode - current app mode
- getNavigationStatus - progress, currentSegment, leftDistance, leftTime, etc
max-klaus
reviewed
Jul 30, 2020
| import android.os.Parcel; | ||
| import android.os.Parcelable; | ||
|
|
||
| public class APosition implements Parcelable { |
There was a problem hiding this comment.
- APosition > ALocation
- ALocation immutable
- ALocation extends AidlParams
- positionType > locationType and it should be explained in the method's description
|
Can I know the reason the pull request wasn't merged |
|
It has conflicts (now) with OsmandAidlServiceV2.java and we've just lost initiator of this request. Cause there was no info around, we decided it's not needed. Probably you agree: any code needs a user otherwise there is always a price for something that nobody needs. |
ntruchsess
pushed a commit
to ntruchsess/Osmand
that referenced
this pull request
Apr 9, 2024
aidl method stub to get location aidl output parameter as parcelable APosition constructor params order fixed Order of AIDL methods rearranged; Added getCurrentRouteSegmentIndex() & getRouteCreationTime(); get rid of duplicate class LatLonParcelable, use ALatLon instead; added getRoute() aidl api method; added getRoutePoints() aidl method getApplicationMode() aidl method added Refactored due to osmandapp#9304 (comment) && osmandapp#9304 (comment)
ntruchsess
pushed a commit
to ntruchsess/Osmand
that referenced
this pull request
Apr 9, 2024
aidl method stub to get location aidl output parameter as parcelable APosition constructor params order fixed Order of AIDL methods rearranged; Added getCurrentRouteSegmentIndex() & getRouteCreationTime(); get rid of duplicate class LatLonParcelable, use ALatLon instead; added getRoute() aidl api method; added getRoutePoints() aidl method getApplicationMode() aidl method added Refactored due to osmandapp#9304 (comment) && osmandapp#9304 (comment)
ntruchsess
pushed a commit
to ntruchsess/Osmand
that referenced
this pull request
Apr 9, 2024
aidl method stub to get location aidl output parameter as parcelable APosition constructor params order fixed Order of AIDL methods rearranged; Added getCurrentRouteSegmentIndex() & getRouteCreationTime(); get rid of duplicate class LatLonParcelable, use ALatLon instead; added getRoute() aidl api method; added getRoutePoints() aidl method getApplicationMode() aidl method added Refactored due to osmandapp#9304 (comment) && osmandapp#9304 (comment)
ntruchsess
pushed a commit
to ntruchsess/Osmand
that referenced
this pull request
Apr 9, 2024
aidl method stub to get location aidl output parameter as parcelable APosition constructor params order fixed Order of AIDL methods rearranged; Added getCurrentRouteSegmentIndex() & getRouteCreationTime(); get rid of duplicate class LatLonParcelable, use ALatLon instead; added getRoute() aidl api method; added getRoutePoints() aidl method getApplicationMode() aidl method added Refactored due to osmandapp#9304 (comment) && osmandapp#9304 (comment)
ntruchsess
pushed a commit
to ntruchsess/Osmand
that referenced
this pull request
Apr 9, 2024
aidl method stub to get location aidl output parameter as parcelable APosition constructor params order fixed Order of AIDL methods rearranged; Added getCurrentRouteSegmentIndex() & getRouteCreationTime(); get rid of duplicate class LatLonParcelable, use ALatLon instead; added getRoute() aidl api method; added getRoutePoints() aidl method getApplicationMode() aidl method added Refactored due to osmandapp#9304 (comment) && osmandapp#9304 (comment)
ntruchsess
pushed a commit
to ntruchsess/Osmand
that referenced
this pull request
Apr 10, 2024
aidl method stub to get location aidl output parameter as parcelable APosition constructor params order fixed Order of AIDL methods rearranged; Added getCurrentRouteSegmentIndex() & getRouteCreationTime(); get rid of duplicate class LatLonParcelable, use ALatLon instead; added getRoute() aidl api method; added getRoutePoints() aidl method getApplicationMode() aidl method added Refactored due to osmandapp#9304 (comment) && osmandapp#9304 (comment)
ntruchsess
pushed a commit
to ntruchsess/Osmand
that referenced
this pull request
Apr 10, 2024
aidl method stub to get location aidl output parameter as parcelable APosition constructor params order fixed Order of AIDL methods rearranged; Added getCurrentRouteSegmentIndex() & getRouteCreationTime(); get rid of duplicate class LatLonParcelable, use ALatLon instead; added getRoute() aidl api method; added getRoutePoints() aidl method getApplicationMode() aidl method added Refactored due to osmandapp#9304 (comment) && osmandapp#9304 (comment)
ntruchsess
pushed a commit
to ntruchsess/Osmand
that referenced
this pull request
Apr 10, 2024
aidl method stub to get location aidl output parameter as parcelable APosition constructor params order fixed Order of AIDL methods rearranged; Added getCurrentRouteSegmentIndex() & getRouteCreationTime(); get rid of duplicate class LatLonParcelable, use ALatLon instead; added getRoute() aidl api method; added getRoutePoints() aidl method getApplicationMode() aidl method added Refactored due to osmandapp#9304 (comment) && osmandapp#9304 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends external api with get_route function which returns current route and also extends aidl api functionality with get_position function to retrieve various positions (current fixed location by now).