Fix #6838 Announce the change of street names #8787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One road may be result of several streets changing one into another. In that case OsmAnd didn't indicate that street name would change, because thare was no turn left/right in the route. Commit adds the new feature. When two segments of stright part route have different street names, a new 'stright' direction with the new name will be inserted into the list of directions. This is not applied to roads that have international/national refs, like 'E 101'
|
Hello @vshcherb, I can't assign a reviewer to this PR. Could you help? |
vshcherb
reviewed
Apr 14, 2020
| String curStreetName = s.getObject().getName(ctx.getSettings().MAP_PREFERRED_LOCALE.get(), | ||
| ctx.getSettings().MAP_TRANSLITERATE_NAMES.get()); | ||
| String curIntRef = s.getObject().getValue("int_ref"); | ||
| String curRoadRef2 = s.getObject().getValue("road_ref_2"); |
There was a problem hiding this comment.
road_ref_2, int_ref looks strange cause they are specific to some specific map area and it doesn't look as a general solution
vshcherb
added
the
Nice to Have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One road may be result of several streets changing one into another. In that case OsmAnd didn't indicate that street name would change, because thare was no turn left/right in the route.
Commit adds the new feature. When two segments of stright part route have different street names, a new 'stright' direction with the new name will be inserted into the list of directions.
This is not applied to roads that have international/national refs, like 'E 101'