Fix #8323 Add the name of the street driving on #8347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrega
force-pushed
the
cur_street_name
branch
from
955d218
to
98010b1
Compare
Fix bug in improper visibility evaluation of current street name
|
@vshcherb could you review the changes and merge/rebase them? |
Improve composing of current street name.
alrega
force-pushed
the
cur_street_name
branch
from
24da8b6
to
a552830
Compare
|
We're not sure whether it fits all combinations or not, so we need more time to review it & test it. |
vshcherb
added
the
Nice to Have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified source code in order to implement improvement #8323
I've tested changes by using Android Emulator, but not in the street using instant hardware.
Could you share APK file built in your CI with this change? I'd like to make system testing. I have aarch64 (arm64-v8a) CPU. Alternatively, please let me know Gradle task name to build APK locally.
Thank you in advance.