Fix 1164 wikivoyage sorting #19858
Merged
Fix 1164 wikivoyage sorting #19858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" show "London" on the 5 place
Chumva
reviewed
May 14, 2024
| public void sortSearchResults(@NonNull List<WikivoyageSearchResult> results, String searchQuery) { | ||
| String searchQueryLC = searchQuery.toLowerCase(); | ||
| results.sort((sr1, sr2) -> { | ||
| int sr1Comparison = collator.compare(sr1.getArticleTitle(), searchQuery); |
There was a problem hiding this comment.
getArticleTitle() we can store in local variables
Chumva
reviewed
May 14, 2024
| } else { | ||
| String title1LC = sr1.getArticleTitle().toLowerCase(); | ||
| String title2LC = sr2.getArticleTitle().toLowerCase(); | ||
| if (title1LC.contains(searchQueryLC) && !title2LC.contains(searchQueryLC)) { |
There was a problem hiding this comment.
result from contains also store in boolean variables
vshcherb
reviewed
May 14, 2024
| int sr2Comparison = collator.compare(sr2.getArticleTitle(), searchQuery); | ||
|
|
||
| if (sr1Comparison == 0 && sr2Comparison != 0) { | ||
| return -1; |
There was a problem hiding this comment.
comparator should always return Integer.compare or String.compare methods to avoid in consistency, this comparator should be rewritten without ifs !=, check Search results comparator
vshcherb
reviewed
May 16, 2024
| case CONTAINS_OF_TITLE: | ||
| if (sr1Comparison != 0 || sr2Comparison != 0) { | ||
| if (sr1Comparison || sr2Comparison) { |
Dima-1
force-pushed
the
fix-1164-wikivoyage-sorting
branch
from
0fed150
to
4118fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.