Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10239 indicate already uploaded gpx tracks #13007

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

koenigle
Copy link
Contributor

@koenigle koenigle commented Oct 17, 2021

Fix #10239
Indicate which gpx tracks have already been uploaded to OSM. The information is maintained by populating the already existing field lastUploadedTime in the GPX database on a successful upload. A track is already uploaded if lastUploadedTime >= lastModifiedTime.
The additional information is only visible when selecting the upload action in the My Places view.

Screenshot_1634426090

@koenigle koenigle changed the title fix #9525 indicate already uploaded gpx tracks fix #10239 indicate already uploaded gpx tracks Oct 17, 2021
@vshcherb vshcherb added the Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning label Oct 17, 2021
@vshcherb
Copy link
Member

This UI is questionable and need to be reviewed by the team

@koenigle
Copy link
Contributor Author

I also struggeled with the UI, thus i'm open to other recommendations to depict this information.

Options i experimented with:

  1. Single icon without text, e.g. the icon which is used for the action itself. However thereby it seems not clear whether already uploaded tracks or tracks which need to be uploaded are indicated. Maybe a good icon can solve this or one has to use two different icons and mark all tracks.
    Positioning:

    • behind track title
    • right beside track time
    • bigger icon on the right hand side where three dots and switches are shown in other views
  2. Icon with text, thus its more clear what is indicated.
    Positioning:

    • behind track title / right beside track time - problem on smaller devices
    • current implementation below other stuff - uploaded tracks and non-uploaded tracks are not of equal height

For all scenarios it seems reasonable to only show the additional information in the upload view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] OSM: Indicate whether a track has been uploaded or not
2 participants