Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to enable track splitting on power status change. #12108

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

blacklion
Copy link

This is implementation of #12097.
This change doesn't have translations for two new strings.

@blacklion
Copy link
Author

I'm not sure about code style, sorry. I've tried to mimic existing one, for example I didn't use final fields as they are not used in "old" code.

Also, I'm not sure, should new non-translated strings be added as-is to non-English resources.

@vshcherb
Copy link
Member

See #12097

This change doesn't have translations for two new strings.
De-register options listeners on plugin unload.
blacklion and others added 2 commits July 18, 2021 16:55
Accept @comradekingu suggestion.

Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Accept @comradekingu suggestion.

Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants