Obtain licence copyright from extratags #1738
Conversation
There was a problem hiding this comment.
The approach looks okay in general but I'm not yet decided if that is something we'd want in the mainline Nominatim or not. If we take it it definitely needs to be configurable. Even if we don't take it here, there might still be ways to ensure that the patch is minimal for you and maintainable. At the moment there are a lot of format changes in the PR which makes it hard to judge how invasive the whole thing is. Can you separate out the format changes into its own PR, then they can simply be merged and this PR is left with the functional changes.
lib/PlaceLookup.php
Outdated
| $licence_copyright_content = $this->oDB->getRow( | ||
| "SELECT extratags -> 'data_licence' AS licence, extratags -> 'data_copyright' AS copyright FROM placex where place_id = :placeid", | ||
| array(':placeid' => $aPlace['place_id']) | ||
| ); |
There was a problem hiding this comment.
You should enable returning extratags per default ($this->bExtratags) and then extract the information from there instead of running another query on the database.
joy-yyd
force-pushed
the
licence_copyright
branch
from
c5f939e
to
2740974
Compare
|
I modify this PR into the functional change. |
The change obtains the licence and copyright content from the customized data which are imported as "extratags" of "data_licence"and "data_copyright". It is related to resolve #1699.
Thanks a lot for your review!