Add DB() method to return underlying maxminddb #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arp242
changed the title
This ties in to my other patch at [1]; my goal is that geoIP entries are inserted "on the fly" in the SQL database (which simplifies some queries) when they're first seen; this removes the need to pre-populate the database, makes sure the SQL database matches with the GeoIP database, and future-proofs things better (new countries come in to existence; for example the list I previously used didn't include XK/Kosovo). Right now there is no easy way to get at the maxminddb reader; I'd have to create my own little struct which wraps the mmdbreader and scans in the correct types. Not very difficult, but this is a bit easier. [1]: oschwald/maxminddb-golang#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ties in to my other patch at 1; my goal is that geoIP entries are
inserted "on the fly" in the SQL database (which simplifies some
queries) when they're first seen; this removes the need to pre-populate
the database, makes sure the SQL database matches with the GeoIP
database, and future-proofs things better (new countries come in to
existence; for example the list I previously used didn't include
XK/Kosovo).
Right now there is no easy way to get at the maxminddb reader; I'd have
to create my own little struct which wraps the mmdbreader and scans in
the correct types. Not very difficult, but this is a bit easier.