Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic adapter for public Tableau visualizations #453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlncn
Copy link

@mlncn mlncn commented Jul 29, 2021

No description provided.

@oscarotero
Copy link
Owner

Hi. Thanks for your contribution. I just have a couple of changes:

@mlncn
Copy link
Author

mlncn commented Jul 30, 2021

Thank you! Is a code detector needed? Tableau doesn't return a code (that i can find) so we just build one.

@oscarotero
Copy link
Owner

Mmm, I think your code is using the v3.x version of Embed, instead of v4.x.

In v4.x, all code detectors must return a EmbedCode instance (no matter if the code is returned by the site or hand-built).

Could you convert this code to v4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants