Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves #183 for packages/orga #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solves #183 for packages/orga #184

wants to merge 1 commit into from

Conversation

M3kH
Copy link

@M3kH M3kH commented Oct 26, 2022

Here we do two things:

  • We use jest with tsconfig.esm.json
  • We fix the test that are failing

Side notes: My worries is that this pattern might be spread across the codebase, this is just what I stumble on.
Destructuring keeps the code concises, I wonder if there would be another way.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022

⚠️ No Changeset found

Latest commit: b924c03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant