Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: test if service_plan is null #1

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Fix: test if service_plan is null #1

merged 1 commit into from
Jun 29, 2017

Conversation

T0FFF
Copy link

@T0FFF T0FFF commented Jun 28, 2017

If a service plan is null, an error appears in the console and the list of services is not complete in the space summary view.

@o-orand
Copy link
Member

o-orand commented Jun 29, 2017

Thanks @T0FFF ! I think you're fixing icclab#17. Could you confirm that error occurs on user-provided-service ?

@T0FFF
Copy link
Author

T0FFF commented Jun 29, 2017

Yes, that's right

@o-orand
Copy link
Member

o-orand commented Jun 29, 2017

Before merging, could you update you commit message to add :

You could also propose a PR to icclab repo.

…an is undefined b.getApplicationsForTheSpace...); close icclab#17
@o-orand o-orand merged commit a9a2bef into orange-cloudfoundry:master Jun 29, 2017
@T0FFF T0FFF deleted the contribution branch June 29, 2017 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants