Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __future__.annotations to base sampler #5442

Merged
merged 1 commit into from May 21, 2024
Merged

Add __future__.annotations to base sampler #5442

merged 1 commit into from May 21, 2024

Conversation

nabenabe0928
Copy link
Collaborator

Motivation

Relates to:

Description of the changes

Introduce __future__.annotations to base sampler.

@nabenabe0928
Copy link
Collaborator Author

@contramundum53 @eukaryo Could you review this PR?

eukaryo
eukaryo approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@eukaryo eukaryo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eukaryo eukaryo added the code-fix Change that does not change the behavior, such as code refactoring. label May 13, 2024
@eukaryo eukaryo added this to the v4.0.0 milestone May 13, 2024
@eukaryo eukaryo removed their assignment May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label May 20, 2024
@eukaryo eukaryo removed the stale Exempt from stale bot labeling. label May 21, 2024
@eukaryo eukaryo assigned not522 and unassigned contramundum53 May 21, 2024
not522
not522 approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@not522 not522 merged commit a9b1c23 into optuna:master May 21, 2024
15 checks passed
@nabenabe0928 nabenabe0928 deleted the code-fix/introduce-future-annotations-to-base-sampler branch May 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not522 not522 not522 approved these changes

@eukaryo eukaryo eukaryo approved these changes

Assignees

@not522 not522

Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nabenabe0928 @not522 @eukaryo @contramundum53