Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify annotations in _brute_force.py #5441

Merged
merged 2 commits into from May 15, 2024

Conversation

eukaryo
Copy link
Collaborator

@eukaryo eukaryo commented May 12, 2024

Motivation

Related to #4508 ,

Description of the changes

Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment!

optuna/samplers/_brute_force.py Outdated Show resolved Hide resolved
@nabenabe0928 nabenabe0928 assigned not522 and nabenabe0928 and unassigned not522 May 13, 2024
@nabenabe0928
Copy link
Collaborator

@not522 Could you review this PR?

@eukaryo eukaryo added the code-fix Change that does not change the behavior, such as code refactoring. label May 13, 2024
@eukaryo eukaryo added this to the v4.0.0 milestone May 13, 2024
Copy link
Collaborator

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 removed their assignment May 13, 2024
Copy link
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@not522 not522 merged commit 2b6a36f into optuna:master May 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-fix Change that does not change the behavior, such as code refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants