Suppress warnings from numpy in hypervolume computation
#5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabenabe0928
reviewed
May 8, 2024
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
|
In fact, this PR relates to the following issue's comment: Namely, we should probably return |
nabenabe0928
reviewed
May 8, 2024
nabenabe0928
reviewed
May 8, 2024
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
nabenabe0928
reviewed
May 8, 2024
nabenabe0928
approved these changes
May 8, 2024
| assert not np.any(reference_point - rank_i_loss_vals <= 0) | ||
| if not np.isfinite(reference_point).all(): | ||
| return rank_i_indices[:subset_size] | ||
| diff_of_loss_vals_and_ref_point = reference_point - rank_i_loss_vals |
There was a problem hiding this comment.
Btw, can we revert here?
There was a problem hiding this comment.
I think the current defensive code is better for when _solve_hssp_on_unique_loss_vals is called from other code in the future.
There was a problem hiding this comment.
Ok, then let's keep the current code!
|
@not522 |
|
Could you remove |
not522
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to reduce warning
RuntimeWarning: invalid value encountered in subtractin unittests.Related to issue #3815 .
Description of the changes
I applied
with np.errstate(invalid='ignore'):to minimum extent necessary and suppressed warnings.