-
-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop implicit create-study in ask
command
#5415
Drop implicit create-study in ask
command
#5415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add tests to confirm that that ask
command fails on non-exist studies?
Co-authored-by: Naoto Mizuno <gobou522@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your update. LGTM.
This pull request has not seen any recent activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have a comment. PTAL.
This pull request has not seen any recent activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Motivation
I want
ask
command to stop implicit create-study.Description of the changes
ask
command with a custom error message.Note
I believe that the usage of the CLI should be similar to the usage of the python library. When using optuna in python, user must call
optuna.create_study
method explicitly. Therefore, I want to introduce this change.