Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix broken build #160

wants to merge 2 commits into from

Conversation

faust64
Copy link

@faust64 faust64 commented Nov 22, 2019

Following on #159

@annieweng points out we now need Go >= 1.9 to build klar.

Following on optiopay#159

@annieweng points out we now need Go >= 1.9 to build klar.
Copy link

@NexoMichael NexoMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faust64
Copy link
Author

faust64 commented Aug 1, 2020

Lately, I've had further issues building Klar.
Using the Dockerfile previously proposed in this PR, it would fail with the following error:

+ go get -d github.com/optiopay/klar
+ go build ./src/github.com/optiopay/klar
# github.com/stretchr/testify/assert
src/github.com/stretchr/testify/assert/assertions.go:1703:5: undefined: errors.Is
src/github.com/stretchr/testify/assert/assertions.go:1726:6: undefined: errors.Is
src/github.com/stretchr/testify/assert/assertions.go:1749:5: undefined: errors.As
src/github.com/stretchr/testify/assert/assertions.go:1766:7: undefined: errors.Unwrap
src/github.com/stretchr/testify/assert/assertions.go:1770:7: undefined: errors.Unwrap

Not quite understanding what was going on, I just tried to re-upgrade Go.
Arbitrarily picked 1.13.
"works on my laptop".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants