Remove dependency of reflection for TestNG #1112
Conversation
The PaxExam listener makes use of reflection to disable configuration methods. This is NOT needed because the TestNG API has Provided setters via which these can be set. The reason why this change is required is because TestNG in its upcoming version is going to be Changing the data type of these two attributes viz “m_beforeTestMethods” and “m_afterTestMethods”
|
Note: I tried to sign up to jira to log a ticket, but I am having difficulties with it. I see this error (it looks like I still need to get permission for this project in jira) 
|
|
@krmahadevan, Thanks! All OPS4J projects switched from Jira to GitHub Issues. |
|
@oliverlietz - Ah ok! I was referring to the instructions detailed here which said need Jira ticket. Please let me know if we need a github issue for this PR because it's not fixing anything but just changing how the listener interacts with TestNG. For an end user it shouldn't really matter because the functionality would still remain the same. |
|
ping @oliverlietz - Can you please let me know if there's anything pending from my side that needs to be completed so that this PR can be merged? |
* update TestNG to 7.10.2 * incorporate extended PR #1112 from @krmahadevan
|
@krmahadevan, In future, please create a GitHub issue, follow the Boy Scout Rule and sign your commits. I've incorporated your patch as part of #1117. Thanks! |
The PaxExam listener makes use of reflection
to disable configuration methods.
This is NOT needed because the TestNG API has
Provided setters via which these can be set.
The reason why this change is required is because
TestNG in its upcoming version is going to be
Changing the data type of these two attributes
viz “m_beforeTestMethods” and “m_afterTestMethods”