New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #14698: Add ability to generate X sample translation opportunities on local dev server for the contributor dashboard #20278
base: develop
Are you sure you want to change the base?
Conversation
Hi @amaanlari please assign the required reviewer(s) for this PR. Thanks! |
… Proceeds to ‘it’ Block or another 'it' block/spec Despite Failure in ‘beforeAll’ setup or any other failure in the intial specs. (oppia#20192) * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates
PTAL @StephenYu2018 @seanlip |
Unassigning @amaanlari since a re-review was requested. @amaanlari, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM for two codeowner files.
Assigning @kevintab95 for code owner reviews. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several concerns.
core/templates/pages/admin-page/activities-tab/admin-dev-mode-activities-tab.component.html
Outdated
Show resolved
Hide resolved
core/templates/pages/admin-page/activities-tab/admin-dev-mode-activities-tab.component.spec.ts
Outdated
Show resolved
Hide resolved
core/templates/pages/admin-page/activities-tab/admin-dev-mode-activities-tab.component.ts
Outdated
Show resolved
Hide resolved
Unassigning @StephenYu2018 since the review is done. |
Hi @amaanlari, it looks like some changes were requested on this pull request by @StephenYu2018. PTAL. Thanks! |
PTAL @StephenYu2018 |
Unassigning @amaanlari since a re-review was requested. @amaanlari, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my remaining review comment. Then I'll approve the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Unassigning @StephenYu2018 since they have already approved the PR. |
PTAL @kevintab95 |
Overview
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
Successful.generation.of.exps.webm
non-admin.cannot.generate.webm
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers