Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution dashboard admin change: Add overall item count to contributor dashboard admin stats table #20186

Merged
merged 62 commits into from May 13, 2024
Merged

Contribution dashboard admin change: Add overall item count to contributor dashboard admin stats table #20186

merged 62 commits into from May 13, 2024

Conversation

stevenjgodfrey
Copy link
Collaborator

Overview

Add overall item count to contributor dashboard admin stats table

  1. This PR fixes or fixes part of Fix key release blockers of the contributor admin dashboard #19570 .
  2. This PR does the following: Add overall item count to contributor dashboard admin stats table

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

after.mp4

stevenjgodfrey and others added 30 commits December 21, 2023 13:27
@stevenjgodfrey
Changes to contributor-dashboard-admin to appear correctly, to reduce…
6bea1a4 
… number of calls to fetchContributorAdminStats, to subscribe in the correct order
@stevenjgodfrey
Add a test to contributor-dashboard-admin unit tests to ensure coverage
a83ee38
@stevenjgodfrey
Merge remote-tracking branch 'upstream/develop' into cont-dash-admin-…
806ddca 
…change

merge user_services
@stevenjgodfrey
increase coverage of contributor-admin-dashboard page tests
ea34f9b
@stevenjgodfrey
increase coverage of contributor-admin-dashboard page tests further
771d86b
@stevenjgodfrey
Merge remote-tracking branch 'upstream/develop' into cont-dash-admin-…
151c599 
…change

Merge upstream
@stevenjgodfrey
Merge remote-tracking branch 'upstream/develop' into cont-dash-admin-…
2f15db8 
…change

merge with develop
@stevenjgodfrey
fix e2e test error by reducing elements to 1, as unseen component rem…
2647812 
…oved. Removed call to classroom/math as it is no longer added by default.
@stevenjgodfrey
Merge branch 'develop' into cont-dash-admin-change
9d30da1
@stevenjgodfrey
remove browser debug
e5e1363
@stevenjgodfrey
acl decorator changed to open access for classroom id to name
163aad0
@stevenjgodfrey
fixed classroom linting error
3ef76b0
@stevenjgodfrey
fixed further linting error in classroom
c9825fa
@stevenjgodfrey
fix typescipt check error in contributor-dashboard-admin-stats-backen…
675ef92 
…d-api.service test
@stevenjgodfrey
fix typescript check failure in contributor-dashboard-admin-stats-bac…
a792c43 
…kend service
@stevenjgodfrey
Merge remote-tracking branch 'upstream/develop' into cont-dash-admin-…
c5e1316 
…change
@stevenjgodfrey
fix code coverage failure
d501132
@stevenjgodfrey
removed unnecessary test, and export
0ae3a9a
@stevenjgodfrey
Merge remote-tracking branch 'upstream/develop' into cont-dash-admin-…
011bf36 
…change

merge develop
@stevenjgodfrey
add coverage to contributor dashboard admin test
5d22759
@stevenjgodfrey
Merge branch 'cont-dash-admin-change' of https://github.com/stevenjgo…
85c60c7 
…dfrey/oppia into cont-dash-admin-change

merge in from develop
@stevenjgodfrey
Merge branch 'develop' into cont-dash-admin-change
876eb5d
@stevenjgodfrey
Merge branch 'develop' into cont-dash-admin-change
18a7c40
@stevenjgodfrey
Merge remote-tracking branch 'upstream/develop' into cont-dash-admin-…
427b850 
…change

merge from develop
@stevenjgodfrey
Improve test files to make language used more meaningful
f183cdf
@stevenjgodfrey
Merge remote-tracking branch 'upstream/develop' into cont-dash-admin-…
9bddce1 
…change

merge with develop
@stevenjgodfrey
tidied up use of domain constants and expectations of tests
f20e55d
@stevenjgodfrey
Merge branch 'cont-dash-admin-change' of https://github.com/stevenjgo…
b37414b 
…dfrey/oppia into cont-dash-admin-change

pull from remote
@stevenjgodfrey
Merge remote-tracking branch 'upstream/develop' into cont-dash-admin-…
9646579 
…change

merge with develop
@stevenjgodfrey
fixed indentation issue
80e7c46
StephenYu2018
StephenYu2018 requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@StephenYu2018 StephenYu2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 concerns before approving of this PR.

...oard-admin-page/contributor-dashboard-tables/contributor-admin-stats-table.component.spec.ts Outdated Show resolved Hide resolved
...oard-admin-page/contributor-dashboard-tables/contributor-admin-stats-table.component.spec.ts Outdated Show resolved Hide resolved
@oppiabot OppiaBot
Copy link

oppiabot bot commented Apr 26, 2024

Unassigning @StephenYu2018 since the review is done.

@oppiabot OppiaBot
Copy link

oppiabot bot commented Apr 26, 2024

Hi @stevenjgodfrey, it looks like some changes were requested on this pull request by @StephenYu2018. PTAL. Thanks!

@oppiabot OppiaBot
Copy link

oppiabot bot commented May 3, 2024

Hi @stevenjgodfrey, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added stale and removed stale labels May 3, 2024
@stevenjgodfrey
Copy link
Collaborator Author

@StephenYu2018 PTAL

@oppiabot oppiabot bot assigned StephenYu2018 and unassigned stevenjgodfrey May 6, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented May 6, 2024

Unassigning @stevenjgodfrey since a re-review was requested. @stevenjgodfrey, please make sure you have addressed all review comments. Thanks!

StephenYu2018
StephenYu2018 approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@StephenYu2018 StephenYu2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot OppiaBot
Copy link

oppiabot bot commented May 6, 2024

Unassigning @StephenYu2018 since they have already approved the PR.

@stevenjgodfrey
Copy link
Collaborator Author

@Nik-09 PTAL

chris7716
chris7716 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@chris7716 chris7716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot oppiabot bot unassigned chris7716 May 7, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented May 7, 2024

Unassigning @chris7716 since they have already approved the PR.

@chris7716
Copy link
Contributor

@Nik-09 PTAL

Nik-09
Nik-09 approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@Nik-09 Nik-09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stevenjgodfrey LGTM

@Nik-09 Nik-09 assigned stevenjgodfrey and unassigned Nik-09 May 13, 2024
@oppiabot oppiabot bot added the PR: LGTM label May 13, 2024
@oppiabot OppiaBot
Copy link

oppiabot bot commented May 13, 2024

Hi @stevenjgodfrey, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@chris7716 chris7716 added this pull request to the merge queue May 13, 2024
Merged via the queue into oppia:develop with commit ff90095 May 13, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@chris7716 chris7716 chris7716 approved these changes

@Nik-09 Nik-09 Nik-09 approved these changes

@StephenYu2018 StephenYu2018 StephenYu2018 approved these changes

Assignees

@stevenjgodfrey stevenjgodfrey

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stevenjgodfrey @chris7716 @seanlip @Nik-09 @StephenYu2018