Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #18384: Reusable card component for learner dashboard redesign #20185

Merged
merged 87 commits into from May 13, 2024

Conversation

amyyeung17
Copy link
Collaborator

Overview

This PR addresses part of the 2nd breakpoint of #18384, adding a new reusable card component.

Includes 3 new files:

  • lesson-card-component.ts
  • lesson-card-component.spec.ts
  • lesson-card-component.html

This reusable card component essentially consolidates these files in summary-tile beginning with:

  • lesson-story-summary-tile
  • exploration-summary-tile
  • collection-summary tile

Additional notes:

  • Exploration progress is used with a placeholder value until changes are finalized.
  • Goal and learner group tags are to be implemented later

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

reusable-card.mov

Copy link

oppiabot bot commented May 5, 2024

Hi @amyyeung17, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks!

@amyyeung17 amyyeung17 requested a review from nikitaevg May 8, 2024 16:33
@amyyeung17 amyyeung17 assigned nikitaevg and unassigned amyyeung17 May 8, 2024
@oppiabot oppiabot bot unassigned nikitaevg May 9, 2024
Copy link

oppiabot bot commented May 9, 2024

Unassigning @nikitaevg since they have already approved the PR.

Copy link

oppiabot bot commented May 9, 2024

Unassigning @DubeySandeep since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label May 9, 2024
Copy link

oppiabot bot commented May 9, 2024

Hi @amyyeung17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@seanlip seanlip added this pull request to the merge queue May 13, 2024
Merged via the queue into oppia:develop with commit ecec43b May 13, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants