Creators and Learners can access voiceovers with accent #20163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_voice_artists
…r_voice_artists
…r_voice_artists
…r_voice_artists
…voiceovers_with_accent
…r_voice_artists
…r_voice_artists
…voiceovers_with_accent
…voiceovers_with_accent_creators
Nik-09
changed the title
Nik-09
commented
May 23, 2024
| @@ -494,7 +494,7 @@ class ClassifierDict(TypedDict): | |||
| ALPHANUMERIC_REGEX = r'^[A-Za-z0-9]+$' | |||
|
|
|||
| # A regular expression for language accent code. | |||
| LANGUAGE_ACCENT_CODE_REGEX = r'^(([a-z]+)-)+([A-Z]+)$' | |||
There was a problem hiding this comment.
This regex will fail for accent code zh-CN-sichuan. Hence modified.
| @@ -33,7 +33,7 @@ class VoiceoverAdminDataHandler( | |||
| URL_PATH_ARGS_SCHEMAS: Dict[str, str] = {} | |||
| HANDLER_ARGS_SCHEMAS: Dict[str, Dict[str, str]] = {'GET': {}} | |||
|
|
|||
| @acl_decorators.can_access_voiceover_admin_page | |||
There was a problem hiding this comment.
Language accent master list should also be accessed in exp-player page, hence we need to make this open_access
Nik-09
commented
May 24, 2024
There was a problem hiding this comment.
Hi @vojtechjelinek @lkbhitesh07 @Lawful2002 can you please take a look at this PR once you are free?
Currently, I am working on fixing the tests.
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The PR introduces the changes so that creators and voiceover artists can now add voiceovers for state content in a specific accent of a language. And learners can access those voiceovers on the exploration player page.
This feature will be hidden behind the feature flag to smoothly launch the functionality.
Essential Checklist
Please follow the instructions for making a code change.
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Description: The below video demonstrates that voice artists can add manual voiceover using the new UI for the English language in a Canadian accent.
add_voiceover_in_a_language.mp4
Description: The below video demonstrates that voice artists can add manual voiceovers using the new UI for English in a Canadian accent and Hindi language in an Indian accent.
add_voiceover_in_two_different_languages.mp4
Description: The below video demonstrates that learners can access English voiceover in the Canadian language.
learning_in_english.online-video-cutter.com.mp4
Description: The below video demonstrates that learners can access Hindi voiceover in the Indian language.
learning_in_hindi.mp4
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers