Fix #20003: Adjust "My Dashboard" button's position when "Review Lowest Scored Skill" button appears

[LKMartin12]

Overview

1. This PR fixes The ‘My Dashboard’ button is not positioned correctly when the ‘Review Lowest Scored Skill’ button appears in the Oppia Maths Classroom/Practice Session on the test server.” #20003 .

2. This PR does the following: The previous implementation of the file question-player.component.html was making two footers, in which there would be two buttons in the first footer and only one in the second footer.

   But the list used to iterate through how many buttons would be placed in each footer was iterating a list of three element (contained all three buttons in it) which was making the css property justify-content leave space for a third button in the first footer (it isn't a problem to do this in the second footer as we want to have only one button on the right side, which will happen as long another button is considered prior to him).

   This led to the "Review Lowest Scored Skill" button being correctly placed but, as space was left for a third button, the "My Dashboard" button wouldn't stick to the right. In order for this to happen, I made it so that we use the same list (so that we don't have to add new methods to the ts file or tests for it) and only iterate through the first two elements, which will always be the buttons in the first footer.

   If the button "Review Lowest Scored Skill" doesn't appear it is still important to continue counting him, as we want to make the "My Dashboard" button stick to the right either way.

Proof that changes are correct

Essential Checklist

• I have linked the issue that this PR fixes in the "Development" section of the sidebar.
• I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
• The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
• I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

[oppiabot]

Hi @LKMartin12, can you complete the following:

1. The body of this PR is missing the proof that changes are correct section, please update it to include the section.
   Thanks!

[oppiabot]

Assigning @Nik-09 for the first pass review of this PR. Thanks!

[Ash-2k3]

Hey @Nik-09, PTAL at this PR, Thanks!

[Nik-09]

Hi @LKMartin12 Can you please add before and after changes, this helps the reviewers to understand the UI changes quickly.

Thanks

[oppiabot]

Hi @LKMartin12, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[LKMartin12]

Hi @Nik-09 sorry for the late response! As requested here is how the code looked like before

and here is how the code looks like after the changes

If any more clarifications are necessary, I'll be at your disposal. Thank You for your time!

[oppiabot]

Hi @LKMartin12, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[LKMartin12]

@Nik-09 When you are available could you take a look at it? The bot is trying to close it ahaha, Thank You!

[seanlip]

@LKMartin12 Please see the last point of the "essential checklist" in the description of the PR. There is a specific syntax you need to use when assigning PRs to others -- if you don't do that, then they won't see it.

Try that and feel free to let us know if it doesn't work. Thanks!

[oppiabot]

Hi @LKMartin12, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[LKMartin12]

@LKMartin12 Please see the last point of the "essential checklist" in the description of the PR. There is a specific syntax you need to use when assigning PRs to others -- if you don't do that, then they won't see it.

Try that and feel free to let us know if it doesn't work. Thanks!

Ok @seanlip , I´ll take a look and update it as soon as I can

[oppiabot]

Hi @LKMartin12, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[LKMartin12]

@{{Nik-09}}PTAL

[LKMartin12]

@Nik-09 PTAL

[oppiabot]

Unassigning @LKMartin12 since a re-review was requested. @LKMartin12, please make sure you have addressed all review comments. Thanks!

[Nik-09]

Sorry, @LKMartin12 for the delay. I will take a look tomorrow morning.