New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign splash page #20155
base: develop
Are you sure you want to change the base?
Redesign splash page #20155
Conversation
Hi @AkashPaloju please assign the required reviewer(s) for this PR. Thanks! |
I will assign the reviewers once all tests are passed. Thanks! |
Current Status: Waiting for reply on this query before the 'a11y' commit |
@AkashPaloju I've replied to the query. Are you planning to finish this PR? Please also note that your CI checks are failing. |
Also, one note -- where possible, try to optimize the image sizes, especially for the larger files. Thanks! |
Thanks @AkashPaloju, I am also adding the design leads for a review of the video! |
Hi, Web version:
Mobile version:
Tablet version:
Thank you for your great work! |
Hi Team, For Web: Kurin has done a great job capturing most of the changes needed, especially the mobile CTA alignments issues. No other issues on my end. Nice work all! |
Hi, @S4v8n , For the 4th point about the Dark Orange color #B25239 please refer this query Thanks! |
Hi, I have addressed the comments, Could you PTAL? @nikitaevg |
Unassigning @AkashPaloju since a re-review was requested. @AkashPaloju, please make sure you have addressed all review comments. Thanks! |
@AkashPaloju Please reply to all the comments by @nikitaevg, thanks. |
Hi Akash, thank you for the latest video update. The desktop version looks better. There are couple things I noticed. In Desktop version:
One small thing I notice in the Mobile portrait mode.
Thank you again for your work. It is looking great. Best, |
Thanks @S4v8n , I will do the remaining changes but I won't be to do the white background thing for the curved shapes given my ongoing GSoC period with Oppia. |
Sounds good @AkashPaloju, Thanks for the response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Unassigning @nikitaevg since they have already approved the PR. |
Hi @AkashPaloju, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
The time stamps here are for the first video on this page: Learn anything, anywhere with Oppia—your free educational platform. At 0:07 — having your *own account. And add a line break before Through our Learner Groups. 0:10: Oppia is a non-profit project built by volunteers from around the world. We always need more people to create, improve and translate lessons, contribute graphics, and more! Also only capitalize Subscribe in Subscribe to our newsletter at the bottom. Since we are moving away from title case, don’t capitalize Teachers or Parents in the header for “For Teachers” and “For Parents” Also, there’s not consistency with these buttons. Are we doing title case in buttons? I thought we weren’t, but I’m unsure. @seanlip |
Hi @S4v8n , |
Hi Akash, Thank you for the latest changes. Here are my comments. These are smaller things I noticed that more spacing related. Web:
Mobile Tablet Thank you again for your work, it is looking really good. Best, |
@S4v8n , I have addressed your comments and verified things you said, PTAL at the updated video. Thanks! |
@AkashPaloju looks good! Thanks for the quick turn around. I have no further comments. |
@seanlip Reviewers and Designers have approved the changes and all tests are passed. Please add this to Merge queue. Thanks! |
Overview
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
Desktop & Mobile devices
splash-revisions.webm
Hover effects
splash-hover-effects.webm
Lighthouse tests in a11y
Screencast.from.23-04-24.10.45.31.PM.IST.webm
RTL Layout:
Screencast from 23-04-24 10:43:28 PM IST.webm
Slow Network:
Screencast.from.23-04-24.10.51.37.PM.IST.webm
PR Pointers