Fix part of #17712: Acceptance test for logged-in learner #20043

AFZL210 · 2024-03-24T15:20:44Z

Overview

This PR fixes part of Acceptance Testing - covering all user journeys in form of user stories #17712 .
This PR does the following: Acceptance test for a logged-in user(here) can add an exploration from the community library to 'Play later,' remove it from the learner dashboard, search and play the exploration, give feedback, and report it.

Essential Checklist

The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
I have followed the instructions for making a code change.
I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)

Proof that changes are correct

Running suite with 1 specs.

------------------------------------
| 1. Suite started: Logged-in User |
------------------------------------
[2024-03-24 20:33:54 +0530] [147698] [INFO] Starting gunicorn 20.1.0
[2024-03-24 20:33:54 +0530] [147698] [INFO] Listening at: http://0.0.0.0:24999 (147698)
[2024-03-24 20:33:54 +0530] [147698] [INFO] Using worker: sync
[2024-03-24 20:33:54 +0530] [147747] [INFO] Booting worker with pid: 147747
[2024-03-24 20:33:54 +0530] [147749] [INFO] Starting gunicorn 20.1.0
[2024-03-24 20:33:54 +0530] [147749] [INFO] Listening at: http://0.0.0.0:24998 (147749)
[2024-03-24 20:33:54 +0530] [147749] [INFO] Using worker: sync
[2024-03-24 20:33:54 +0530] [147752] [INFO] Booting worker with pid: 147752
[datastore] Mar 24, 2024 8:33:55 PM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Mar 24, 2024 8:33:55 PM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
[datastore] Mar 24, 2024 8:33:55 PM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Mar 24, 2024 8:33:55 PM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
[2024-03-24 20:33:57 +0530] [147845] [INFO] Starting gunicorn 20.1.0
[2024-03-24 20:33:57 +0530] [147845] [INFO] Listening at: http://0.0.0.0:24997 (147845)
[2024-03-24 20:33:57 +0530] [147845] [INFO] Using worker: sync
[2024-03-24 20:33:57 +0530] [147859] [INFO] Booting worker with pid: 147859
[2024-03-24 20:34:02 +0530] [148003] [INFO] Starting gunicorn 20.1.0
[2024-03-24 20:34:02 +0530] [148003] [INFO] Listening at: http://0.0.0.0:24996 (148003)
[2024-03-24 20:34:02 +0530] [148003] [INFO] Using worker: sync
[2024-03-24 20:34:02 +0530] [148006] [INFO] Booting worker with pid: 148006
[datastore] Mar 24, 2024 8:34:02 PM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Mar 24, 2024 8:34:02 PM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
[datastore] Mar 24, 2024 8:34:06 PM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Mar 24, 2024 8:34:06 PM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
[2024-03-24 20:34:32 +0530] [148513] [INFO] Starting gunicorn 20.1.0
[2024-03-24 20:34:32 +0530] [148513] [INFO] Listening at: http://0.0.0.0:24995 (148513)
[2024-03-24 20:34:32 +0530] [148513] [INFO] Using worker: sync
[2024-03-24 20:34:32 +0530] [148519] [INFO] Booting worker with pid: 148519
[2024-03-24 20:34:34 +0530] [148596] [INFO] Starting gunicorn 20.1.0
[2024-03-24 20:34:34 +0530] [148596] [INFO] Listening at: http://0.0.0.0:24994 (148596)
[2024-03-24 20:34:34 +0530] [148596] [INFO] Using worker: sync
[2024-03-24 20:34:34 +0530] [148599] [INFO] Booting worker with pid: 148599
[datastore] Mar 24, 2024 8:34:34 PM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Mar 24, 2024 8:34:34 PM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
/tmp/tmpgXaNdC/lib/python3.8/site-packages/elasticsearch/connection/base.py:200: ElasticsearchWarning: Elasticsearch built-in security features are not enabled. Without authentication, your cluster could be accessible to anyone. See https://www.elastic.co/guide/en/elasticsearch/reference/7.17/security-minimal-setup.html to enable security.
  warnings.warn(message, category=ElasticsearchWarning)
ERROR:root:This app cannot send emails to users.

Spec started : Logged-in User should add exploration to play later then remove it and report it
LOG: Exploration with title Test Exploration exists in Play Later
LOG: Removed exploration from play later
LOG: Exploration with title Test Exploration does not exists in Play Later
[datastore] Mar 24, 2024 8:34:58 PM io.gapi.emulators.grpc.GrpcServer$3 operationComplete
[datastore] INFO: Adding handler(s) to newly registered Channel.
[datastore] Mar 24, 2024 8:34:58 PM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[datastore] INFO: Detected HTTP/2 connection.
LOG: Exploration completed successfully!
[2024-03-24 20:34:59 +0530] [149626] [INFO] Starting gunicorn 20.1.0
[2024-03-24 20:34:59 +0530] [149626] [INFO] Listening at: http://0.0.0.0:24993 (149626)
[2024-03-24 20:34:59 +0530] [149626] [INFO] Using worker: sync
[2024-03-24 20:34:59 +0530] [149629] [INFO] Booting worker with pid: 149629
ERROR:root:This app cannot send emails to users.
LOG: Exploration reported with message Testing the functionality.
LOG: Feedback has been given with the message: Testing Feedback functionality
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
ERROR:root:Frontend error: 
Failed to execute 'convertToSpecifiedUnits' on 'SVGLength': Could not resolve relative length.

    at URL: http://localhost:8181/create/T80dvnaC21u1#/feedback
LOG: 1 feedback from testLearner is present.
-> Passed [ Took 29.647 seconds ]

References:

Proof of changes in Arabic language

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

…y later test

oppiabot · 2024-03-24T15:20:56Z

Assigning @StephenYu2018 for the first pass review of this PR. Thanks!

oppiabot · 2024-03-24T15:31:18Z

Hi @AFZL210. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

DubeySandeep · 2024-03-27T09:10:49Z

@StephenYu2018 Can you please take a pass on this PR?

StephenYu2018

3 concerns to address before merging.

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

core/tests/puppeteer-acceptance-tests/user-utilities/logged-in-users-utils.ts

oppiabot · 2024-03-28T21:33:28Z

Unassigning @StephenYu2018 since the review is done.

…n-user-3

jnvtnguyen · 2024-04-10T19:05:59Z

@AFZL210 Add the console error as a regex to match it inside puppeteer-testing-utilities/console-reporter.ts under CONSOLE_ERRORS_TO_FIX with a TODO pointing to the existing issue or create a new issue if there isn't one filed.

…n-user-3

seanlip · 2024-04-12T18:51:51Z

.github/workflows/e2e_lighthouse_performance_acceptance_tests.yml

@@ -318,6 +318,7 @@ jobs:
            - logged-in-user-tests/click-all-buttons-on-navbar
            - logged-in-user-tests/click-all-links-in-about-oppia-footer
            - logged-in-user-tests/click-all-links-on-get-started-page
+            - logged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it


later is misspelled

seanlip · 2024-04-12T18:52:13Z

core/tests/puppeteer-acceptance-tests/puppeteer-testing-utilities/test-constants.ts

@@ -32,6 +32,7 @@ export default {
    Contact: 'http://localhost:8181/contact',
    ContributorDashboardAdmin:
      'http://localhost:8181/contributor-admin-dashboard',
+    LearnerDashboard: 'http://localhost:8181/learner-dashboard',


Keep this list in alphabetical order.

seanlip · 2024-04-12T18:52:37Z

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

+      'exploration_creator@example.com'
+    );
+
+    await explorationCreator.createEndExploration();


What does this mean? I don't think it makes sense.

seanlip · 2024-04-12T18:53:41Z

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

+        'Test Exploration'
+      );
+      await testLearner.expectReachedTheEndOfExploration();
+      await testLearner.reportTheExploration('Testing the functionality');


reportExploration

rahat2134 · 2024-04-16T12:30:03Z

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

+        'Testing Feedback functionality'
+      );
+
+      await explorationCreator.openExplorationEditor('Test Exploration');


Can we have a more specific method name. Why we are giving input as 'Test Exploration' in openExplorationEditor?
Can we have something like openExplorationWithTitle('test Exploration')

rahat2134

Reviewed top level tests and utils. PTAL.

rahat2134 · 2024-04-16T12:40:00Z

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

+      'exploration_creator@example.com'
+    );
+
+    await explorationCreator.createEndExploration();


We can have something like createExplorationWithMinimumInteraction...

rahat2134 · 2024-04-16T12:42:13Z

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

+  }, DEFAULT_SPEC_TIMEOUT);
+
+  it(
+    'should add exploration to play later then remove it then give feedback and report it',


should add exploration to play later, remove it, give feedback, and finally report it.

rahat2134 · 2024-04-16T12:46:26Z

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

+    'should add exploration to play later then remove it then give feedback and report it',
+    async function () {
+      await testLearner.navigateToCommunityLibraryPage();
+      await testLearner.findExplorationInCommunityLibrary('Test Exploration');


findExplorationInCommunityLibraryWithTitle('Test Exploration');

rahat2134 · 2024-04-16T12:47:28Z

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

+
+      await testLearner.navigateToLearnerDashboardPage();
+      await testLearner.openCommunityLessonsTab();
+      await testLearner.expectExplorationWithTitleToBePresentInPlayLater(


expectExplorationToBePresentInPlayLaterWithTitle('test Exploration');

rahat2134 · 2024-04-16T12:48:26Z

...ogged-in-user-tests/try-to-add-exploration-to-play-latee-give-feedback-and-report-it.spec.ts

+        'Test Exploration'
+      );
+      await testLearner.removeExplorationFromPlayLater();
+      await testLearner.expectExplorationWithTitleToBeAbsentInPlayLater(


See above comment.

rahat2134 · 2024-04-16T13:41:42Z

core/tests/puppeteer-acceptance-tests/user-utilities/logged-in-users-utils.ts

+
+  /**
+   * This function to add exploration to play later.
+   */


rahat2134 · 2024-04-16T13:42:33Z

core/tests/puppeteer-acceptance-tests/user-utilities/logged-in-users-utils.ts

+
+  /**
+   * This function to remove exploration from play later.
+   */


rahat2134 · 2024-04-16T13:43:19Z

core/tests/puppeteer-acceptance-tests/user-utilities/logged-in-users-utils.ts

+   */
+  async addExplorationToPlayLater(): Promise<void> {
+    await this.page.hover(communityExplorationCard);
+    await this.page.click('.e2e-test-add-to-playlist-btn');


dont use direct selector, this.clickOn();

rahat2134 · 2024-04-16T13:45:19Z

core/tests/puppeteer-acceptance-tests/user-utilities/logged-in-users-utils.ts

+      await this.navigateToCreatorDashboardPage();
+    }
+
+    const allExplorations = await this.page.$$('.oppia-activity-summary-tile');


explorationsList

rahat2134 · 2024-04-16T14:01:49Z

core/tests/puppeteer-acceptance-tests/user-utilities/logged-in-users-utils.ts

+    await this.clickOn(createExplorationButton);
+    await this.page.waitForSelector(
+      `${dismissWelcomeModalSelector}:not([disabled])`
+    );


I don't think it is required here. Please check.

rahat2134 · 2024-04-16T14:08:56Z

Tests are failing at CLI, I think some waitFor need to be corrected.

AFZL210 · 2024-04-17T06:56:16Z

Tests are failing at CLI, I think some waitFor need to be corrected.

It's because of the mobile test. I'm moving this PR to draft, as the mobile test can only be implemented after this issue is fixed.

oppiabot · 2024-04-24T07:30:20Z

Hi @AFZL210, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

seanlip · 2024-04-24T13:02:01Z

Tests are failing at CLI, I think some waitFor need to be corrected.

It's because of the mobile test. I'm moving this PR to draft, as the mobile test can only be implemented after this issue is fixed.

@AFZL210 We can't have this PR be open but blocked long-term. Are you planning to help address the issue with #19443?

AFZL210 · 2024-04-24T13:14:00Z

Tests are failing at CLI, I think some waitFor need to be corrected.

It's because of the mobile test. I'm moving this PR to draft, as the mobile test can only be implemented after this issue is fixed.

@AFZL210 We can't have this PR be open but blocked long-term. Are you planning to help address the issue with #19443?

Make sense, Yes just confirmed with harsh he still haven't got the solution, I will try to reproduce the issue today and try to find the fix.

oppiabot · 2024-05-01T13:47:13Z

Hi @AFZL210, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

…n-user-3

oppiabot · 2024-05-08T17:25:31Z

Hi @AFZL210, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot · 2024-05-11T11:50:43Z

Hi @AFZL210. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

AFZL210 added 6 commits March 23, 2024 21:36

Fix part of oppia#17712: add acceptance test for logged-in user - pla…

f0cf855

…y later test

update test

a2f1128

update test

2a94e43

change test name

a82acad

update test name

4ec6d3d

update logs

e53a7ed

AFZL210 requested review from a team as code owners March 24, 2024 15:20

AFZL210 requested review from StephenYu2018 and DubeySandeep March 24, 2024 15:20

AFZL210 marked this pull request as draft March 24, 2024 15:20

oppiabot bot assigned StephenYu2018 Mar 24, 2024

AFZL210 unassigned StephenYu2018 Mar 24, 2024

update message

82ecacd

AFZL210 marked this pull request as ready for review March 24, 2024 15:25

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label Mar 24, 2024

oppiabot bot assigned AFZL210 Mar 24, 2024

resolve conflicts

525e65e

oppiabot bot removed the PR: don't merge - HAS MERGE CONFLICTS label Mar 24, 2024

AFZL210 assigned DubeySandeep and StephenYu2018 Mar 24, 2024

DubeySandeep removed their assignment Mar 27, 2024

StephenYu2018 requested changes Mar 28, 2024

View reviewed changes

oppiabot bot unassigned StephenYu2018 Mar 28, 2024

AFZL210 added 2 commits March 29, 2024 14:46

Merge branch 'develop' into fix17712-add-acceptance-test-for-logged-i…

b0363b3

…n-user-3

avoid using waitForTimeout

87a2657

Ash-2k3 assigned DubeySandeep and unassigned AFZL210 Apr 10, 2024

jnvtnguyen assigned AFZL210 and unassigned DubeySandeep Apr 10, 2024

AFZL210 added 5 commits April 11, 2024 01:17

add error to fix

6fc633c

avoid using bypass flag

39b2474

fix timeout

43cdc9c

wait for refresh

6c3445b

Merge branch 'develop' into fix17712-add-acceptance-test-for-logged-i…

20f35bf

…n-user-3

seanlip reviewed Apr 12, 2024

View reviewed changes

rahat2134 reviewed Apr 16, 2024

View reviewed changes

AFZL210 marked this pull request as draft April 17, 2024 06:56

oppiabot bot added the stale label Apr 24, 2024

oppiabot bot removed the stale label Apr 24, 2024

oppiabot bot added the stale label May 1, 2024

Merge branch 'develop' into fix17712-add-acceptance-test-for-logged-i…

68e3666

…n-user-3

oppiabot bot removed the stale label May 1, 2024

oppiabot bot added stale PR: don't merge - HAS MERGE CONFLICTS labels May 8, 2024

oppiabot bot closed this May 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix part of #17712: Acceptance test for logged-in learner #20043

Fix part of #17712: Acceptance test for logged-in learner #20043

AFZL210 commented Mar 24, 2024 •

edited

oppiabot bot commented Mar 24, 2024

oppiabot bot commented Mar 24, 2024

DubeySandeep commented Mar 27, 2024 •

edited

StephenYu2018 left a comment

oppiabot bot commented Mar 28, 2024

jnvtnguyen commented Apr 10, 2024 •

edited

seanlip Apr 12, 2024

seanlip Apr 12, 2024

seanlip Apr 12, 2024

seanlip Apr 12, 2024

rahat2134 Apr 16, 2024

rahat2134 left a comment

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 Apr 16, 2024

rahat2134 commented Apr 16, 2024

AFZL210 commented Apr 17, 2024

oppiabot bot commented Apr 24, 2024

seanlip commented Apr 24, 2024

AFZL210 commented Apr 24, 2024

oppiabot bot commented May 1, 2024

oppiabot bot commented May 8, 2024

oppiabot bot commented May 11, 2024

Fix part of #17712: Acceptance test for logged-in learner #20043

Fix part of #17712: Acceptance test for logged-in learner #20043

Conversation

AFZL210 commented Mar 24, 2024 • edited

Overview

Essential Checklist

Proof that changes are correct

Proof of changes in Arabic language

PR Pointers

oppiabot bot commented Mar 24, 2024

oppiabot bot commented Mar 24, 2024

DubeySandeep commented Mar 27, 2024 • edited

StephenYu2018 left a comment

Choose a reason for hiding this comment

oppiabot bot commented Mar 28, 2024

jnvtnguyen commented Apr 10, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rahat2134 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rahat2134 commented Apr 16, 2024

AFZL210 commented Apr 17, 2024

oppiabot bot commented Apr 24, 2024

seanlip commented Apr 24, 2024

AFZL210 commented Apr 24, 2024

oppiabot bot commented May 1, 2024

oppiabot bot commented May 8, 2024

oppiabot bot commented May 11, 2024

AFZL210 commented Mar 24, 2024 •

edited

DubeySandeep commented Mar 27, 2024 •

edited

jnvtnguyen commented Apr 10, 2024 •

edited