Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/51376 - Add Primer::OpenProject::InputGroup captions #71

Conversation

akabiru
Copy link
Member

@akabiru akabiru commented Jan 29, 2024

What are you trying to accomplish?

https://community.openproject.org/wp/51376

Support first party captions on the Primer::OpenProject::InputGroup component- providing the caption via the text_input breaks the traling_action layout, hence the system argument is also denied.

Screenshots

Integration

List the issues that this change affects.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Jan 29, 2024

⚠️ No Changeset found

Latest commit: d812d83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@akabiru akabiru self-assigned this Jan 29, 2024
@akabiru
Copy link
Member Author

akabiru commented May 24, 2024

Stale- will re-open when working on it

@akabiru akabiru closed this May 24, 2024
@akabiru akabiru deleted the bug/51376-primeropenprojectinputgroup-component-text-input-breaks-with-captions branch May 24, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant