[36233] OpenProject Dark Mode #15366
Conversation
…s it should only be applied for the accessibility themes for now
…-openproject-dark-mode-mvp
|
Hi @HDinger, |
There was a problem hiding this comment.
Hi @bsatarnejad
I know that this is still in a Draft state so I did not check the code into detail yet. I just found some places where I originally used the old (deprecated) variables which are now not supported any more.
| --avatar-border-color: var(--avatar-borderColor); | ||
| --list-item-hover--border-color: var(--control-transparent-borderColor-hover); | ||
| --list-item-hover--color: var(--fgColor-default); | ||
| --list-item-hover--color: var(--color-action-list-item-default-hover-bg); |
There was a problem hiding this comment.
That variable does not exist any more.
| --main-menu-fieldset-header-color: var(--fgColor-muted) !important; | ||
| --main-menu-border-width: 1px; | ||
| --button-default-borderColor-rest: var(--borderColor-default); | ||
| --button--border-color: var(--color-btn-border); |
There was a problem hiding this comment.
--color-btn-border does also not exist any more. It is now named --button-default-borderColor-rest
| --main-menu-border-width: 1px; | ||
| --button-default-borderColor-rest: var(--borderColor-default); | ||
| --button--border-color: var(--color-btn-border); | ||
| --button--primary-font-color: var(--button-primary-fgColor-rest); | ||
| --button--primary-background-hover-color: var(--button-primary-bgColor-hover); | ||
| --button--primary-background-color: var(--button-primary-bgColor-rest); |
There was a problem hiding this comment.
It looks like this doesn't work correctly:
| --button--primary-background-hover-color: var(--button-primary-bgColor-hover); | ||
| --button--primary-background-color: var(--button-primary-bgColor-rest); | ||
| --button--active-border-color: var(--borderColor-default); | ||
| --button--active-border-color: var(--color-btn-border); | ||
| --button--font-color: var(--color-btn-text); |
There was a problem hiding this comment.
That variable also does not exist any more.
| @@ -79,7 +79,7 @@ $pagination--font-size: 0.8125rem | |||
| min-width: 25px | |||
| text-align: center | |||
| padding: 3px 3px | |||
| background: #f8f8f8 | |||
| background: var(--button--background-color) | |||
There was a problem hiding this comment.
--button--background-color is also deprecated by now
| @@ -93,17 +93,17 @@ li.change | |||
|
|
|||
| &::before | |||
| content: '▸' | |||
| color: var(--fgColor-muted) | |||
| color: var(--color-fg-muted) | |||
There was a problem hiding this comment.
Please undo this change as fgColor-muted is the correct variable name
| font-weight: var(--base-text-weight-bold) | ||
| width: 100% | ||
| text-align: left | ||
|
|
||
| &:hover | ||
| background-color: #f5faff | ||
| color: #333 | ||
| background-color: var(--list-item-hover--color) |
There was a problem hiding this comment.
--list-item-hover--color does not exist any more
https://community.openproject.org/projects/openproject/work_packages/36233/activity