Feature/52144 changing a persisted list

[toy]

OP#52144

[ulferts]

Very solid work, @toy. The behaviour itself is implemented very thoroughly and the only thing I can complain about behaviour wise is something I only spotted because of some previous bugfix.

If a list employs a custom field as a filter or a column, is persisted, and then the custom field is deleted, a valid subset is generated to prevent errors from being displayed. The same scenario (which can only happen after sharing is implemented) is one where an admin only filter or column is part of a list which is then called by a non admin user. In that case, because the filters/columns are changed, the notification "List modified" is displayed although the user did not change anything. I guess the best approach would be to avoid the query to be flagged as dirty in case an invalid filter/column/order is removed.

[toy]

If a list employs a custom field as a filter or a column, is persisted, and then the custom field is deleted, a valid subset is generated to prevent errors from being displayed. The same scenario (which can only happen after sharing is implemented) is one where an admin only filter or column is part of a list which is then called by a non admin user. In that case, because the filters/columns are changed, the notification "List modified" is displayed although the user did not change anything. I guess the best approach would be to avoid the query to be flagged as dirty in case an invalid filter/column/order is removed.

See 5fb2ce0 and b94ccb2

[ulferts]

Once again, solid work @toy