Fixes two long-standing issues with logread: #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) async reconnect for logd 2) be able to send logs to different targets in one process. The latter will allow to remove ugly stuff in startup script where two copies of logread might be started Check for related pr for this. Signed-off-by: Serhii Ivanov <icegood1980@gmail.com>
|
437 line diffstat and 4 lines explaining what they do, that is 2 orders of magnitude |
In other words, you should split this into (multiple) separate commits and add more details in the commit descriptions |
icegood
added a commit
to icegood/openwrt
that referenced
this pull request
Jan 2, 2024
It will make logger more consistent to other ones plus one process will reduce consuption of memory 2) Get rid of mixed log_size parameter. Instead, two separated log_max_file_size (for maximal file size in case of logging in file) and log_buffer_size (for memory size in logd) are introduced. Therefore, user will not guess anymore, what actually log_size did. Dependencies: openwrt/ubox#2 Signed-off-by: Serhii Ivanov <icegood1980@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for related pr for this (in near future).