freeswitch: add patch moving package to PCRE2 #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I think I'm reaching a whole new level on persuading this project of remove PCRE from OpenWRT LOL |
30 tasks
Add paending patch moving package to PCRE2 as PCRE is EOL and won't receive any updates anymore. These patch were run uder the freeswitch CI and were validated with their unit tests. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Ansuel
force-pushed
the
freeswitch-pcre2
branch
from
a6796d8
to
04b1dea
Compare
|
This is definitely another level. Thanks Christian. |
|
Okay guys, I see that @Ansuel created PR in upstream - signalwire/freeswitch#2299 Since we are not getting any attention from devs there. Could we merge this, please and as well backport it to the stable branches as well? We need to move on with PCRE removal. 🙏 |
|
Am 27. April 2024 10:10:23 UTC schrieb Josef Schlehofer ***@***.***>:
Okay guys, I see that @Ansuel created PR in upstream - signalwire/freeswitch#2299
Since we are not getting any attention from devs there. Could we merge this, please and as well backport it to the stable branches as well? We need to move on with PCRE removal. 🙏
Too invasive for me personally. Needs to go upstream first. Too risky otherwise in my opinion.
|
|
Upstream devs are occupied, @Ansuel did so amazing work while submitting PRs to upstream for other packages, which was migrated to PCRE2, but this one is the last package. It is a pity that we can not say that PCRE2 migration is done until someone merge this thing. :-( Maybe someone can reach them to look into it with higher priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add paending patch moving package to PCRE2 as PCRE is EOL and won't receive any updates anymore.
These patch were run uder the freeswitch CI and were validated with their unit tests.
Maintainer: Sebastian Kemper sebastian_ml@gmx.net
@BKPepe probably will take a bit for this to be actually merged upstream but just for reference also here...