nghttp3: update to 1.2.0 #23743
Merged
nghttp3: update to 1.2.0 #23743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update PKG_RELEASE to be apk-compatible * update PKG_SOURCE/PKG_SOURCE_URL so that it builds Signed-off-by: Stan Grishin <stangri@melmac.ca>
BKPepe
requested changes
Mar 25, 2024
|
Please, avoid marking the conversation as resolved, if you did not do anything. |
BKPepe
reviewed
Mar 31, 2024
Comment on lines
+7
to
+8
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz | ||
| PKG_SOURCE_URL:=https://github.com/ngtcp2/$(PKG_NAME)/releases/download/v$(PKG_VERSION)/ |
There was a problem hiding this comment.
I wondered what was wrong that you needed to introduce such a change, and it seems you reported it to upstream, but in the commit description nor in this PR, you did not say why. That's why I replied to the issue, which you created in upstream - ngtcp2/nghttp3#202 (comment)
It would be great if you describe it more closely, so we know what is happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: x86_64, Sophos XG-135r3, OpenWrt 23.05.2
Description: