Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nebula: prepare migration to APK #23715

Merged
merged 1 commit into from Mar 24, 2024
Merged

Conversation

stangri
Copy link
Member

@stangri stangri commented Mar 23, 2024

Maintainer: me
Compile tested: x86_64, Sophos XG-135r3, OpenWrt 23.05.2

Signed-off-by: Stan Grishin <stangri@melmac.ca>
@stangri stangri self-assigned this Mar 23, 2024
@BKPepe
Copy link
Member

BKPepe commented Mar 23, 2024

I am thinking that there should be commit description, which leads or described, what you done. I know it, but in the future, we will look back in the history and we would not know why.

Otherwise commit itself and the changes are understandable for me. You are not trying to slip any more changes like in other PRs, which were not relevant to APK migration.

@BKPepe
Copy link
Member

BKPepe commented Mar 23, 2024

Anyway, I think this transition or migration to APK should be done via treewide commit because otherwise, we will open PR to each package, and it would not be good.

@stangri stangri merged commit cd46684 into openwrt:master Mar 24, 2024
12 checks passed
@BKPepe
Copy link
Member

BKPepe commented Mar 24, 2024

Hola... why are you creating pull requests and then merging it by your own? It is like #yolo. I should not waste my time on this until is being reflected. I kindly ask you to follow what is being written here: https://openwrt.org/submitting-patches and in the CONTRIBUTING.md. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants