Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.05] dnsmasq: version 2.90 #14853

Merged
3 commits merged into from Mar 18, 2024
Merged

Conversation

stangri
Copy link
Member

@stangri stangri commented Mar 12, 2024

Bump to 2.90 to get upstream's fix for DNSSEC KeyTrap (CVE-2023-50387, CVE-2023-50868) among many other goodies and fixes (notably, upstream 568fb024... fixes a UAF in cache_remove_uid that was routinely crashing dnsmasq in my deployment).

Catch up our 200-ubus_dns.patch, too.

Signed-off-by: Nathaniel Wesley Filardo nwfilardo@gmail.com
(cherry picked from commit 838a27f)

@github-actions github-actions bot added core packages pull request/issue for core (in-tree) packages release/23.05 pull request/issue targeted (also) for OpenWrt 23.05 release labels Mar 12, 2024
@systemcrash
Copy link
Contributor

See also 694e647 (@stangri you I think can include this commit in your PR )

@@ -8,13 +8,13 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=dnsmasq
PKG_UPSTREAM_VERSION:=2.89
PKG_UPSTREAM_VERSION:=2.90
PKG_VERSION:=$(subst test,~~test,$(subst rc,~rc,$(PKG_UPSTREAM_VERSION)))
PKG_RELEASE:=4

This comment was marked as resolved.

@stangri
Copy link
Member Author

stangri commented Mar 17, 2024

See also 694e647 (@stangri you I think can include this commit in your PR )

Thanks @systemcrash I hope I didn't eff it up.

Copy link

@egc112 egc112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @schuettecarsten to set PKG_RELEASE to 1
I had to add a newline at the end.
Otherwise it compiled and ran fine on my EA8500, thanks @stangri

@dave14305
Copy link

For people using dnsmasq-full with dnssec, there is a bug in logging that creates log spam. Fixed upstream by https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commitdiff;h=1ed783b8d7343c42910a61f12a8fc6237eb80417

@stangri
Copy link
Member Author

stangri commented Mar 17, 2024

@MkQtS @hardfalcon @schuettecarsten @egc112 -- this is a cherry-pick PR, I can include other commits from main branch but I'm not adding anything which was not already merged in main.

@dave14305 thank you, if/when the fix is merged into master, I can add another commit to this PR (if it's not merged by then).

@systemcrash
Copy link
Contributor

For people using dnsmasq-full with dnssec, there is a bug in logging that creates log spam. Fixed upstream by https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commitdiff;h=1ed783b8d7343c42910a61f12a8fc6237eb80417

This should go in as an own commit in master. If that gets cherry picked and supersedes this, that's fine.

I don't understand why this in itself should take such a long time.

ecsv and others added 3 commits March 18, 2024 21:55
If the dnsmasq process forks to handle TCP connections, it closes the ubus
context. But instead of changing the daemon wide pointer to NULL, only the
local variable was adjusted - and this portion of the code was even dropped
(dead store) by some optimizing compilers.

It makes more sense to change the daemon->ubus pointer because various
functions are already checking it for NULL. It is also the behavior which
ubus_destroy() implements.

Fixes: d8b33da ("dnsmasq: add support for monitoring and modifying dns lookup results via ubus")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
(cherry picked from commit 711dcb7)
Bump to 2.90 to get upstream's fix for DNSSEC KeyTrap (CVE-2023-50387,
CVE-2023-50868) among many other goodies and fixes (notably, upstream
568fb024... fixes a UAF in cache_remove_uid that was routinely crashing
dnsmasq in my deployment).

Catch up our 200-ubus_dns.patch, too.

Signed-off-by: Nathaniel Wesley Filardo <nwfilardo@gmail.com>
(cherry picked from commit 838a27f)
dnsmasq was recently updated to 2.90, but PKG_RELEASE was not reset to 1.

Fixes: 838a27f ("dnsmasq: version 2.90")
Signed-off-by: Robert Marko <robimarko@gmail.com>
(cherry picked from commit 694e647)
@openwrt-bot openwrt-bot closed this pull request by merging all changes into openwrt:openwrt-23.05 in 853b638 Mar 18, 2024
@hauke
Copy link
Member

hauke commented Mar 18, 2024

I created a PR for the extra patches: #14927

@GetVladimir
Copy link

There is a new PR that's a continuation of this update. It allows for the full feature set of the new options from Dnsmasq 2.90 to be configurable via uci on OpenWrt: #14975

It adds the options for:
--filter-rr
--cache-rr
--dns-rr

and also adds a custom Dnsmasq configuration field via uci that supports any valid Dnsmasq option, so that we don't have to add each feature manually on every update like the ones above, and hopefully makes configurations a little bit easier.

If possible, please review the PR #14975 or add a suggestion if you think there is anything that can be improved or needs to be changed.

The main post for the PR and the details on how to try out and revert back the files is on the OpenWrt Forum: https://forum.openwrt.org/t/add-dnsmasq-custom-options-field-in-luci-gui/193184/18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages release/23.05 pull request/issue targeted (also) for OpenWrt 23.05 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet