Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: allow to define additional configs #728

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-gave
Copy link

@a-gave a-gave commented Feb 3, 2024

This introduces the possibility of passing additional configs to the request.

Only the few not related to kernel/packages, as they are not recompiled by the imagebuilder, would make sense.
For example, to request a specific name/number for a firmware image:

CONFIG_VERSION_DIST=MyRouterOS
CONFIG_VERSION_NUMBER=1.6

Or to request a format other than the default format for the output firmware image, for example:

# CONFIG_TARGET_ROOTFS_SQUASHFS is not set
CONFIG_TARGET_ROOTFS_JFFS2=y

@aparcar
Copy link
Member

aparcar commented Feb 5, 2024

Please fix the failing test.

@a-gave a-gave force-pushed the feat/allow-to-define-additional-configs branch from 3ef4de3 to 60b45b9 Compare February 6, 2024 18:25
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6f634f8) 80.94% compared to head (60b45b9) 86.70%.

❗ Current head 60b45b9 differs from pull request most recent head 88f632b. Consider uploading reports for the commit 88f632b to get more accurate results

Files Patch % Lines
asu/build.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   80.94%   86.70%   +5.75%     
==========================================
  Files          15       15              
  Lines         976      985       +9     
==========================================
+ Hits          790      854      +64     
+ Misses        186      131      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aparcar aparcar force-pushed the feat/allow-to-define-additional-configs branch from 60b45b9 to 88f632b Compare February 21, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants