New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Try to prevent harder buildbot failures #5
base: main
Are you sure you want to change the base?
Conversation
Merging pull request #14218 (with all 190 CI checks green) resulted in buildbot failures in `Kernel/CollectDebug` step, likely due to the fact, that CI builds don't use same config options as on buildbot, specifically CI builds currently don't have `COLLECT_KERNEL_DEBUG` config option enabled. So lets try to prevent those regressions in the future by aligning the CI build process with the build config options used later on the buildbots. References: 066b0fee7668 ("kernel: copy only *.ko for debug info") References: openwrt/openwrt#14218 Signed-off-by: Petr Štetiar <ynezz@true.cz>
@ynezz any reason why they are not part of the CONFIG_BUILDBOT option? |
Uh, they're part of |
@ynezz guess the problem is for kernel build where we would build way too much packages. Should we introduce the CONFIG_CI option? |
Check the diff, I've tried to split it into multiple cheap/expensive parts and tried to enable the expensive parts only where it makes sense.
I would just try to keep the buildbot settings with CI somehow in the sync manually, when we find out buildbot failure like in this case, just enable the test case on the CI, IMO no need to complicate it with some other config option, looks like overkill to me. |
working-directory: openwrt | ||
run: | | ||
echo CONFIG_DEVEL=y >> .config | ||
echo CONFIG_SDK_LLVM_BPF=y >> .config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure where to put this config option, had it initially in the next Configure SDK and IB options used on buildbots
step, will recheck later.
6189e34
to
5613f0d
Compare
I think this looks good |
Merging pull request openwrt/openwrt#14218 (with all 190 CI checks green) resulted in buildbot failures in
Kernel/CollectDebug
step, likely due to the fact, that CI builds don't use same config options as on buildbot, specifically CI builds currently don't haveCOLLECT_KERNEL_DEBUG
config option enabled.So lets try to prevent those regressions in the future by aligning the CI build process with the build config options used later on the buildbots.
References: 066b0fee7668 ("kernel: copy only *.ko for debug info")
References: openwrt/openwrt#14218
Just quickly drafted to start discussion about the improvements, so untested as well...