-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Set default value for maxZoom and limit maxZoom option #188 #248
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,15 @@ export default function extendLeafletModel(echarts) { | |
}, | ||
|
||
setCenterAndZoom(center, zoom) { | ||
// Limit zoom level before setting | ||
zoom = Math.min(zoom, this.getMaxZoom()); | ||
|
||
// If a zoom control exists, adjust its options | ||
const map = this.getLeaflet(); | ||
if (map.zoomControl) { | ||
map.zoomControl.options.maxZoom = this.getMaxZoom(); | ||
} | ||
|
||
this.option.center = center; | ||
this.option.zoom = zoom; | ||
}, | ||
|
@@ -33,7 +42,10 @@ export default function extendLeafletModel(echarts) { | |
}, | ||
|
||
defaultOption: { | ||
mapOptions: {}, | ||
mapOptions: { | ||
zoomDelta: 0.25, // Set zoom sensitivity | ||
zoomSnap: 0.3 // Disable zoom snapping | ||
}, | ||
tiles: [ | ||
{ | ||
urlTemplate: "http://{s}.tile.osm.org/{z}/{x}/{y}.png", | ||
|
@@ -44,6 +56,15 @@ export default function extendLeafletModel(echarts) { | |
}, | ||
], | ||
layerControl: {}, | ||
maxZoom: 15 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we have 15 here right? |
||
}, | ||
|
||
/** | ||
* Get the maximum supported zoom level | ||
* @return {number} | ||
*/ | ||
getMaxZoom() { | ||
return this.option.maxZoom; | ||
}, | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the
maxZoom
is higher? Why hardcoding this value here? Can we get the maxZoom here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nemesifier, I think a maximum zoom level of 12-18 is appropriate. If we zoom beyond that, we encounter empty responses from the tile server.
https://wiki.openstreetmap.org/wiki/Zoom_levels
but now I think if it is not an ideal approach could you please give me some Hints/approaches on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should pass the default config here and get the maxZoom value from it instead of duplicating it here.