Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing a random offset value (jitterAmount) to avoid overlapping #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itsOmSarraf
Copy link

No description provided.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to deal with this problem, we first need to add an example which replicates the issue inside the library, eg:
image

We need nodes of 3 different colors (as we have in openwisp-monitoring, green, yellow and red for ok, problem and critical respectively) all these positioned near each other.

When zooming out, if the problem is resolved, the clusters will not overlap.

The solution you're proposing here doesn't seem to deal with any particular case, it just adds some jitter randomly and I don't believe it's solving the issue.

First, we need to replicate the issue, then we look for solutions.

Have you been able to replicate the issue first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants