Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Show node labels only after a suitable zoom level #148 #165

Merged
merged 4 commits into from
Sep 21, 2022

Conversation

totallynotvaishnav
Copy link
Member

closes #148

@totallynotvaishnav totallynotvaishnav added this to In progress in [GSoC 22] netjsongraph.js via automation Sep 20, 2022
@totallynotvaishnav totallynotvaishnav moved this from In progress to Ready for review in [GSoC 22] netjsongraph.js Sep 20, 2022
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see my comment below.


**Default**: `7`

The zoom level at which the labels are shown. This only works when `render` is set to `map`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let's clarify how it currently works on the logical map.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

[GSoC 22] netjsongraph.js automation moved this from Ready for review to Reviewer approved Sep 21, 2022
@nemesifier nemesifier merged commit a83c2ee into gsoc22 Sep 21, 2022
@nemesifier nemesifier deleted the issues/148-show-labels-after-zoom-level branch September 21, 2022 13:26
[GSoC 22] netjsongraph.js automation moved this from Reviewer approved to Done Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants