Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Show node labels only after hitting a certain zoom level #148

Open
totallynotvaishnav opened this issue Jul 16, 2022 · 1 comment · May be fixed by #187
Open

[change] Show node labels only after hitting a certain zoom level #148

totallynotvaishnav opened this issue Jul 16, 2022 · 1 comment · May be fixed by #187
Labels
enhancement
Projects
[GSoC 22] netjsongraph.js OpenWISP Contributor's Board OpenWISP Priorities for next releases

Comments

@totallynotvaishnav
Copy link
Member

Currently, when we zoom out too much the labels of the nodes look cluttered and they are unreadable. We should allow the library to configure the level of zoom at which we want to start seeing node labels.
Screenshot 2022-07-16 at 10 30 06 PM
@totallynotvaishnav totallynotvaishnav added this to To do in [GSoC 22] netjsongraph.js via automation Jul 16, 2022
@totallynotvaishnav totallynotvaishnav moved this from To do to Backlog in [GSoC 22] netjsongraph.js Aug 9, 2022
@totallynotvaishnav totallynotvaishnav moved this from Backlog to To do in [GSoC 22] netjsongraph.js Sep 11, 2022
@totallynotvaishnav totallynotvaishnav moved this from To do to In progress in [GSoC 22] netjsongraph.js Sep 15, 2022
totallynotvaishnav added a commit that referenced this issue Sep 20, 2022
@totallynotvaishnav
[change] Show node labels only after a suitable zoom level #148
7e2e925 
closes #148
totallynotvaishnav added a commit that referenced this issue Sep 20, 2022
@totallynotvaishnav
[change] Show node labels only after a suitable zoom level #148
c64fe75 
closes #148
@totallynotvaishnav totallynotvaishnav mentioned this issue Sep 20, 2022
Merged
[GSoC 22] netjsongraph.js automation moved this from In progress to Done Sep 21, 2022
totallynotvaishnav added a commit to totallynotvaishnav/netjsongraph.js that referenced this issue Nov 15, 2022
@totallynotvaishnav
[feature] Show node labels only after a suitable zoom level openwisp#148
3e13509 


Closes openwisp#148
totallynotvaishnav added a commit that referenced this issue Nov 16, 2022
@totallynotvaishnav
[feature] Show node labels only after a suitable zoom level #148
8999349 
Closes #148
@nemesifier
Copy link
Member

I am reopening this because I found out how to do this:

graph.echarts.on('graphRoam', function(e) {
  console.log(graph.echarts.getOption().series[0].zoom);
});

@nemesifier nemesifier reopened this Feb 28, 2023
[GSoC 22] netjsongraph.js automation moved this from Done to In progress Feb 28, 2023
@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Feb 28, 2023
@nemesifier nemesifier added this to Backlog in OpenWISP Priorities for next releases via automation Feb 28, 2023
pandafy added a commit that referenced this issue Apr 12, 2023
@pandafy
[change] Graph mode respects showLabelsAtZoomLevel setting #148
f217864 
Closes #148
@pandafy pandafy linked a pull request Apr 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
OpenWISP Contributor's Board
  
To do (general)
OpenWISP Priorities for next releases
  
Backlog
[GSoC 22] netjsongraph.js
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[change] Graph mode respects showLabelsAtZoomLevel setting #148 openwisp/netjsongraph.js
2 participants
@nemesifier @totallynotvaishnav