Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update language around assumptions around files and directories #642

Merged
merged 4 commits into from
May 15, 2024
Merged

Update language around assumptions around files and directories #642

merged 4 commits into from
May 15, 2024

Conversation

vsmalladi
Copy link

@vsmalladi vsmalladi commented May 10, 2024 •
edited

Checklist

  • Pull request details were added to CHANGELOG.md
  • Valid examples WDL's were added or updated to the SPEC.md (see the guide on writing markdown tests)

Closes #495

@vsmalladi vsmalladi requested a review from jdidion May 10, 2024 21:58
@vsmalladi vsmalladi linked an issue May 10, 2024 that may be closed by this pull request
assumptions around modifying input files, or making new files in their directories #495
Closed
@rhpvorderman rhpvorderman changed the title Update lanague around assumptions around files and directories Update language around assumptions around files and directories May 13, 2024
rhpvorderman
rhpvorderman approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@rhpvorderman rhpvorderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I found a leftover TODO comment.

SPEC.md Outdated Show resolved Hide resolved
@vsmalladi
Copy link
Author

@rhpvorderman can you re-review?

patmagee
patmagee approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@patmagee patmagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsmalladi vsmalladi merged commit 8af5566 into wdl-1.2 May 15, 2024
@vsmalladi vsmalladi deleted the 495-readonly branch May 15, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmagee patmagee patmagee approved these changes

@jdidion jdidion Awaiting requested review from jdidion

@chapmanb chapmanb Awaiting requested review from chapmanb

@mlin mlin Awaiting requested review from mlin

@geoffjentry geoffjentry Awaiting requested review from geoffjentry

@cjllanwarne cjllanwarne Awaiting requested review from cjllanwarne

@markjschreiber markjschreiber Awaiting requested review from markjschreiber

@rhpvorderman rhpvorderman Awaiting requested review from rhpvorderman

Assignees
No one assigned
Labels
None yet
Projects
WDL v1.2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assumptions around modifying input files, or making new files in their directories
3 participants
@vsmalladi @patmagee @rhpvorderman