Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move contents of PR 524 on top of wdl-1.2 #635

Merged
merged 2 commits into from
May 16, 2024
Merged

Move contents of PR 524 on top of wdl-1.2 #635

merged 2 commits into from
May 16, 2024

Conversation

jdidion
Copy link
Collaborator

@jdidion jdidion commented Apr 9, 2024

Moving contents of #524 on top of wdl-1.2, rather than trying to rebase.

Checklist

  • Pull request details were added to CHANGELOG.md
  • Valid examples WDL's were added or updated to the SPEC.md (see the guide on writing markdown tests)

@jdidion jdidion requested a review from mlin April 9, 2024 20:56
@jdidion jdidion added this to the 1.2 milestone Apr 9, 2024
@vsmalladi vsmalladi self-requested a review May 16, 2024 16:10
vsmalladi
vsmalladi approved these changes May 16, 2024
View reviewed changes
Copy link

@vsmalladi vsmalladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdidion jdidion merged commit 6ab6122 into wdl-1.2 May 16, 2024
@jdidion jdidion deleted the 524/move-to-wdl12 branch May 22, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsmalladi vsmalladi vsmalladi approved these changes

@mlin mlin Awaiting requested review from mlin

Assignees
No one assigned
Labels
enhancement Spec Change
Projects
WDL v1.2
Status: Done
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdidion @vsmalladi