Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move contents of PR 464 on top of wdl-1.2 #634

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

jdidion
Copy link
Collaborator

@jdidion jdidion commented Apr 9, 2024

This PR takes the changes from @mlin PR and moves them to wdl-1.2, rather than trying to rebase.

There was already a relevant example, so I did not add more.

Checklist

  • Pull request details were added to CHANGELOG.md

@jdidion jdidion requested a review from mlin April 9, 2024 19:42
@jdidion jdidion added this to the 1.2 milestone Apr 9, 2024
@vsmalladi vsmalladi self-requested a review May 16, 2024 16:04
SPEC.md Outdated
@@ -3540,8 +3540,7 @@ For example, imagine two versions of file `fs://path/to/A.txt` are being localiz
#### Input Type Constraints

Recall that a type may have a quantifier:
* `?` means that the parameter is optional. A user does not need to specify a value for the parameter in order to satisfy all the inputs to the workflow.
* `+` applies only to `Array` types and it represents a constraint that the `Array` value must contain one-or-more elements.
* `?` means that the input is optional and a caller does not need to specify a value for the input.applies only to `Array` types and it represents a constraint that the `Array` value must contain one-or-more elements.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have a spacing issue:

should be

* `?` means that the input is optional and a caller does not need to specify a value for the input.
* `+` applies only to `Array` types and it represents a constraint that the `Array` value must contain one-or-more elements.

@jdidion jdidion merged commit 89d32f5 into wdl-1.2 May 16, 2024
@jdidion jdidion deleted the 464/move-to-wdl12 branch May 22, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants