Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace emojis with their text codes #617

Closed
wants to merge 3 commits into from
Closed

Conversation

jdidion
Copy link
Collaborator

@jdidion jdidion commented Feb 10, 2024

This fixes linking behavior in IDEs and leaves behavior in GitHub unaffected.

Note that this will break any direct links to section headings that contain emojis!

Checklist

  • Pull request details were added to CHANGELOG.md
  • Valid examples WDL's were added or updated to the SPEC.md (see the guide on writing markdown tests)

@rhpvorderman
Copy link
Contributor

rhpvorderman commented Feb 12, 2024

Emojis are valid unicode, text codes are implementation dependent. So I am more inclined to file a bug with the IDEs rather than fix it here. I would not care very much, if it wasn't for the breaking of third-party links. That is not a good idea for a specification in my opinion.

@jdidion
Copy link
Collaborator Author

jdidion commented Feb 12, 2024

I think I agree. I have found this annoying for a long time and finally decided to try to fix it. But I think the fix is more negative than positive.

@jdidion jdidion deleted the branch wdl-1.1.2 May 22, 2024 19:44
@jdidion jdidion closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants