Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antlr4 python #577

Closed
wants to merge 3 commits into from
Closed

Antlr4 python #577

wants to merge 3 commits into from

Conversation

luyang93
Copy link

CHANGELOG

  1. In version 1.0.0, Rename lexer to WdlV1Lexer, Rename parser to WdlV1Parser, Rename WdlComments channel to COMMENTS, so add V1 in related files, fix error.
  2. Upgrade antlr4-python3-runtime and pytest, specify Specify ANTLR Parser Generator with version 4.13.0.

make test
python3 -m pytest tests/WdlParserTests.py
================================ test session starts ================================
platform linux -- Python 3.11.3, pytest-7.4.0, pluggy-0.13.1
rootdir: ~/PycharmProjects/wdl/versions/development/parsers/antlr4/Python
collected 13 items

tests/WdlParserTests.py ............. [100%]

================================ 13 passed in 0.90s =================================

make test
python3 -m pytest tests/WdlParserTests.py
================================ test session starts ================================
platform linux -- Python 3.11.3, pytest-7.4.0, pluggy-0.13.1
rootdir: ~/PycharmProjects/wdl/versions/1.0/parsers/antlr4/Python
collected 13 items

tests/WdlParserTests.py ............. [100%]

================================ 13 passed in 0.82s =================================

Signed-off-by: luyang93 <39150988+luyang93@users.noreply.github.com>
Signed-off-by: luyang93 <39150988+luyang93@users.noreply.github.com>
Signed-off-by: luyang93 <39150988+luyang93@users.noreply.github.com>
@jdidion
Copy link
Collaborator

jdidion commented Nov 18, 2023

Thank you @ luyang93! Would you mind moving this PR over to https://github.com/openwdl/wdl-parsers? This is where the grammars and parsers will be maintained from now on.

@vsmalladi
Copy link

@jdidion can we close this since this got moved to a different repo?

@patmagee patmagee closed this May 23, 2024
@jdidion
Copy link
Collaborator

jdidion commented May 23, 2024

The PR never got moved, but I don't see any reason to keep it open. Would be nice if @luyang93 or someone else could move it so the changes don't get lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants