Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expressions in command blocks #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expressions in command blocks #17

wants to merge 1 commit into from

Conversation

mcovarr
Copy link
Contributor

@mcovarr mcovarr commented Feb 19, 2020

No description provided.

patmagee
patmagee requested changes Feb 20, 2020
View reviewed changes
Copy link
Member

@patmagee patmagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and catches the vast majority of casses I can think of. The only thing we might consider adding is an expresson or two containing a call to an engne function

cjllanwarne
cjllanwarne reviewed Feb 20, 2020
View reviewed changes
pytest-wdl-tests/tests/expr/commands/test_expressions_commands.wdl
echo ~{-42}
echo ~{+42}
echo ~{i}
echo ~{+i} # fails in Cromwell 48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably keep these kinds of comments in a Cromwell issue tracker rather than the openWDL spec repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjllanwarne cjllanwarne cjllanwarne left review comments

@patmagee patmagee patmagee requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcovarr @patmagee @cjllanwarne