Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nats package #88

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add nats package #88

wants to merge 6 commits into from

Conversation

lohuza
Copy link

@lohuza lohuza commented Dec 27, 2022

No description provided.

@lohuza lohuza requested a review from calj December 27, 2022 08:31
@lohuza lohuza self-assigned this Dec 27, 2022
Copy link
Contributor

@mod mod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a README.md file which explain how the package should be used, and maybe godoc for the most important file

@calj calj changed the title added nats Add nats package Jan 9, 2023
nats/handler.go Outdated

// For Checking compatibility
var (
_ EventHandler = (*NatsEventHandler)(nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer to put those lines into the test file, even in a test so it's more clear this is testing the interface compliance. It can eventually save few bytes of memory footprint.

@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants