[5.0] Bindings work. #1714
Open
[5.0] Bindings work. #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made SpanAndArrayOverloader overload pointer paramters even if they don't have an explicit length attribute. Made GetReturnOverloader more selective of what functions it overloads.
…meters that should be in but not marked as const. Made out to return overload to always convert the last out parameter to the return type. Fixed issue where overload layers couldn't do fixed statemets in case later overloaders made the variable a local variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Removed automatic length parameter calculations.
Span and array overloading for parameters without explicit size (with a risk of generating a few useless overloads).
Don't generate return overloads for parameters with an explicit size
!= 0.Switch to use
outby default and try to mark all places where automatic detection fails.Only convert
outparameters to return values if they are the lastoutparameter.Testing status
OpenTK.Graphicscompiles.