[5.0] [WIP] Remove vendor postfixes #1578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NogginBops
force-pushed
the
otk5-remove-vendor-names
branch
from
6b27a71
to
a7c1420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR aims to remove vendor prefixes from generated function names where possible.
This is complicated by the fact that some extensions contain functions that are only differentiated by their postfix, so we can only remove the postfix in the context of all other functions in the namespace.
I'm not happy with my initial implementation and will work to make it cleaner and better.
This might involve remaking this PR from scratch.
Testing status
N/A