[WIP] More box rework #1341
Open
[WIP] More box rework #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will be retargeting this PR to OpenTK 5 as we've decided to postpone the Box changes until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR aims to complete the box rework that started in #1037 .
It adds more functions to boxes and optimizes some functions.
This PR also makes Min and Max raw public fields of the Box struct to fall in line more with other math types in OpenTK.
One notable addition is Nan preserving min/max operations.
This is technically a breaking change for
Vector2.ComponentMinandVector2.ComponentMaxbut having them be NaN preserving should be the correct behavior.TODO:
This PR also adds
Round,Ceiling, andFloorfunctions toVector2,Vector3, andVector4.Testing status
Current box unit-tests pass but these should be extended.
Before this PR is done the aim is to have some more unit tests.