Problematic naming of Box2.Contains(Box2 other). Fixes Issue #1330.

[danielscherzer]

Purpose of this PR

Fixing the issue #1330 by changing Box2.Contains(Box2 other) to implement a "to have within" or "superset" operation in the mathematical sense. The current code

public bool Contains(Box2 other)
{
    return _max.X >= other._min.X && _min.X <= other._max.X &&
    _max.Y >= other._min.Y && _min.Y <= other._max.Y;
}

tests for overlap/intersection, so I will move it to a new Box2.Overlaps(Box2 other) method.

• This affects the Math part of OpenTK

Testing status

• I will change the current tests regarding Box2.Contains(Box2 other) to test the new Box2.Overlaps(Box2 other) and include new unit test for the new Box2.Contains(Box2 other) code.

[NogginBops]

How does this PR change with the changes merged in #1037 ?

[danielscherzer]

#1037 changes different parts of the Box code then my PR. So you could merge with #1037 and afterwards I could reapply my changes.

[NogginBops]

Is this still a draft?

[danielscherzer]

sorry! forgot to click read for review!

[NogginBops]

I'm going to retarget this PR to OpenTK 5 as we are moving all Box changes to that version.
You don't have to do anything with this PR, I can fix the retargeting.